SoftwareBrothers / adminjs

AdminJS is an admin panel for apps written in node.js
https://adminjs.co
MIT License
8.06k stars 646 forks source link

fix: running with Node.js 22 #1665

Closed mohd-akram closed 1 week ago

mohd-akram commented 1 month ago

Resolves SyntaxError: Unexpected identifier 'assert' in Node.js 22.

Closes #1663

dziraf commented 1 month ago

Changing the import syntax is not enough, there are extra changes to Babel required + the last time I checked TS highlighted with as an error even though we're already at v5.3+ so it'd be the best to update typescript too.

mohd-akram commented 1 month ago

Thanks, that helped.

Babel was converting it to with type: 'json' (I believe that's the with-legacy option).

Support for import attributes was added in Node.js 18.20 so the CI version needed to be updated.

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 7.8.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: