Closed anthonysutardja closed 10 years ago
Generally looks good. Thanks for the PR. Main things I notice are
The device has a thermostat built on, so we're pulling that data as well as the humidity and gas pressure measurements. Should we make a new class of devices?
I think steve is saying that although it has a thermometer, it is not a thermostat - i.e it is not designed to control an HVAC system. You can just copy it one directory up or create a new directory.
Yep.
I would prefer if the error conditions were less silent. Can you add some logging to things like the ValueError for instance? If they are expected (I have a device that frequently issues invalid data for example) then please add a comment to that effect. Otherwise silently absorbing exceptions is a bit mean for future developers.
Apart from that, LGTM
Sounds good, I'll move it up a dir. Should errors just be a print statement?
Steve can weigh in on what the 'correct' logging facility in sMAP is, but I think Twisted has a logging API
Don't know if you're waiting for signoff here, ship it!
Let me know if I'm doing this right