SoftwareForScience / pulsar-cpp

Cpp rewrite of the sigproc project
Apache License 2.0
2 stars 0 forks source link

Replace string with char in filterbank-core #2

Closed RonaldPhilipsen closed 5 years ago

RonaldPhilipsen commented 5 years ago

[ 30%] Building CXX object libAsteria/filterbank-core/src/CMakeFiles/filterbank-core.dir/filterbank-core.cpp.o In file included from /sfs/Asteria/libAsteria/filterbank-core/src/../include/filterbank-core.h:15:0, from /sfs/Asteria/libAsteria/filterbank-core/src/filterbank-core.cpp:1: /sfs/Asteria/libAsteria/filterbank-core/src/../include/HeaderParam.h:13:17: error: invalid conversion from ‘const char’ to ‘char’ [-fpermissive] char s[80]{"\0"}; ^ /sfs/Asteria/libAsteria/filterbank-core/src/filterbank-core.cpp: In member function ‘char filterbank::read_string(uint32_t&)’: /sfs/Asteria/libAsteria/filterbank-core/src/filterbank-core.cpp:315:60: warning: non-constant array size in new, unable to verify length of initializer-list [enabled by default] char* buffer = new char[(((uint64_t)keylen) + 1)]{ '\0' }; ^ make[2]: [libAsteria/filterbank-core/src/CMakeFiles/filterbank-core.dir/filterbank-core.cpp.o] Error 1 make[1]: [libAsteria/filterbank-core/src/CMakeFiles/filterbank-core.dir/all] Error 2

thomasstolk commented 5 years ago

30 sp