SoftwareUnderstanding / inspect4py

Static code analysis package for Python repositories
https://inspect4py.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
27 stars 10 forks source link

All external dependency #351

Open OEG-Clark opened 2 years ago

OEG-Clark commented 2 years ago

I have reviewed most of the results from the inspect4py, and as far as I can tell, all dependency modules have the same type, which is external. However, from an user perspective, I think if this function or class is inside of this project, it should be internal.

dgarijo commented 2 years ago

I do not understand this issue very well, sorry. Can you provide an example? Thanks!

El mar., 21 jun. 2022 7:06 p. m., Clark Wang @.***> escribió:

I have reviewed most of the results from the inspect4py, and as far as I can tell, all dependency modules have the same type, which is external. However, from an user perspective, I think if this function or class is inside of this project, it should be internal.

— Reply to this email directly, view it on GitHub https://github.com/SoftwareUnderstanding/inspect4py/issues/351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGW3QT2CXYJVPWMRMETVQIAEFANCNFSM5ZNHBKWA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dgarijo commented 2 years ago

So the problem is that all depencies of a file are marked as external. We find no internal dependencies, even those functions that are defined within a package/library.

rosafilgueira commented 2 years ago

Could you give an example,with a repo, or something ?

OEG-Clark commented 2 years ago

Dear Rosa,

Of course, this repo is one of the many tests that I have viewed, and the attached file is the inspect4py result. The dependency part is all external due to the refered line is m+i+'.py', I believe to i , is a function instead of the files.

Best, Clark

At 2022-07-04 18:17:33, "Rosa Filgueira" @.***> wrote:

Could you give an example,with a repo, or something ?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

dgarijo commented 2 years ago

@OEG-Clark, can you please paste the concrete repository where this happens? We have tested one locally, but we saw the internal dependencies showing nicely

OEG-Clark commented 2 years ago

Dear All, This is the result of the first dependencies block of 0101 result. And you could see the pipetools should be internal but it is exteranl.

在 2022-07-04 18:30:41,"Daniel Garijo" @.***> 写道:

@OEG-Clark, can you please paste the concrete repository where this happens? We have tested one locally, but we saw the internal dependencies showing nicely

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

dgarijo commented 2 years ago

you mean the 0101 pipetools?

rosafilgueira commented 2 years ago

Hi @OEG-Clark ,

Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.

If you can actually copy the repo in the body of the message ( and maybe also, include the command that you are using), that will be fantastic.

For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:

''' inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html '''

If I try this test, it detects well the type of dependencies. But it is true, that is just a mini-test!

If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.

Thanks!

OEG-Clark commented 2 years ago

Oh, of course, I will add details in the issue page under issue 38.

At 2022-07-04 19:25:44, "Rosa Filgueira" @.***> wrote:

Hi @OEG-Clark ,

Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.

If you can actually copy paste the

For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:

''' inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html '''

If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.

Thanks!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

OEG-Clark commented 2 years ago

Dear All,

I have added more detail here.

Best Clark

At 2022-07-04 19:25:44, "Rosa Filgueira" @.***> wrote:

Hi @OEG-Clark ,

Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.

If you can actually copy paste the

For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:

''' inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html '''

If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.

Thanks!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>