Dependency Error: External & Internal Type

SoftwareUnderstanding / inspect4py

Static code analysis package for Python repositories

https://inspect4py.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

27 stars 10 forks source link

Dependency Error: External & Internal Type #353

Open OEG-Clark opened 2 years ago

OEG-Clark commented 2 years ago

https://github.com/SoftwareUnderstanding/inspect4py/blob/3ed30dd219dbcb079151906cd68d7556d56fc383/inspect4py/utils.py#L326

Should change this line into: file_module = abs_repo_path + "/" + m + ".py"

OEG-Clark commented 2 years ago

I cannot upload a json file here, but the code is, as you can see, the import from pipetools should be considered as internal, but in the image below labelled as external. Since I think the definition of external/internal should be in the scale of the repo/project.

OEG-Clark commented 2 years ago

And I have printed the path in the code reference above, if it ends with i.py is a function name as a python file.

dgarijo commented 2 years ago

Just FYI, Clark, you can upload txt files if you change the json extension to txt

OEG-Clark commented 2 years ago

directory_info_38.txt.txt

dgarijo commented 2 years ago

Some additional tests need to be added here

rosafilgueira commented 2 years ago

I had a bit of time today, and I think I have solved the problem with the dependencies. It is not 100% garentee ... since more test would be needed, but it seems that my changes, solve the problems found by @OEG-Clark for piptools repo.

See bellow: