SoftwareVerde / bitcoin-cash-specification

Specification of the Bitcoin Cash protocols and consensus

Other

8 stars 5 forks source link

Inaccurate size for input sequence number #27

Closed monsterbitar closed 2 years ago

monsterbitar commented 2 years ago

Paul Chandler found an error in the documentation, on /protocol/blockchain/transaction/transaction-signing in the Bitcoin Cash Signatures section. The table lists:

input sequence number | 8 bytes

But according to https://github.com/bitcoincashorg/bitcoincash.org/blob/master/spec/replay-protected-sighash.md is should be 4 bytes.

monsterbitar commented 2 years ago

Addressed by https://github.com/SoftwareVerde/bitcoin-cash-specification/pull/28

joshmg commented 2 years ago

28 was merged today; closing. Thanks for pointing this out and for the subsequent PR.