joshmg
commented
2 years ago I think now is an appropriate time to merge this, since all of the clients have implemented this upgrade and it is just pending activation. If for some (unlikely) reason the upgrade is rejected then we can simply revert this commit. Thanks for putting these together.
This adds the introspection and math chips verbatim and creates a new fork upgrade entry that references them. Since the fork has not happened yet, this might not be the right time to do this, but early review on the structure and format would be appreciated.
Note that the chips themselves, while containing enough details for a technical implementation and have been through multiple iterations of review and improvement, might still change, for example if a stakeholder provides or wants to update their statement on the chip, or in the case of the math chip the space reserved for statements is deemed no longer relevant due to lack of responses and is removed / clarified further.
I would personally prefer to reference to the chip documents themselves, but I do see the issue with referencing external documentation, and thus copied their current state. Until actual activation, we might need to do a few more updates.