search

SoftwareVerde / bitcoin-cash-specification

Specification of the Bitcoin Cash protocols and consensus
Other
8 stars 5 forks source link

Add HF-20230515 #47

Closed A60AB5450353F40E closed 1 year ago

A60AB5450353F40E commented 1 year ago

Merge #46 first

Is this OK, to make smaller PRs? Feel free to edit the final PR and close others if you want to squash.

A60AB5450353F40E commented 1 year ago

Notice that you pushed multiple commits also seen on another PR to this one, seems to happen with multiple.

Yeah, because instead of making each PR on top of master, I made them on top of the previous PR, idea being that they'd be merged in order so we could update the deployed docs while I work on the rest of the updates. Could've also made one big PR and keep it open, and then people could cherry-pick commits from there, too.

joshmg commented 1 year ago

FWIW, the multiple PRs is nice. I'm not sure what would happen if revisions were to be required in any of the previous PRs though; I assume all subsequent children would also need the update, which could be bad.

joshmg commented 1 year ago

(Re)Pointing out that the links to the CHIP should link to documents within the spec, but for now linking to them this way is better than not linking anything at all.