search

SoftwareVerde / bitcoin-cash-specification

Specification of the Bitcoin Cash protocols and consensus
Other
8 stars 5 forks source link

Update transaction signing with HF-20230515 #51

Closed A60AB5450353F40E closed 5 months ago

A60AB5450353F40E commented 6 months ago 
- Include SIGHASH_UTXOS
- Include token contents
joshmg commented 5 months ago

Thanks @A60AB5450353F40E ! I think this is an overall improvement, for sure; thank you for putting your time into this.

I'm going to merge this PR and at the same time. I'd like you (or myself, or someone else) to take a few minutes in the future to ensure the additions are being mindful of what happens when there is not token data. (To be fair, you've done a reasonably job of that already in this PR). To be specific, under Bitcoin Cash Signatures: 6. Token content of the output being spent -- I'd like to see, "if no token data is present then this field is omitted". (This is also assuming that omission is the correct behavior there; I assume it is, but tbh I forget the specifics at the moment.)

Overall, great job, and thanks again.