search

Sohamlad7 / android_device_motorola_cedric

31 stars 38 forks source link

cedric: add TARGET_PROVIDES_QTI_TELEPHONY_JAR #19

Closed krumboeck closed 6 years ago

krumboeck commented 6 years ago

This patch should solve a conflict with qti-telephony-common. Further infos: https://github.com/LineageOS/android_hardware_lineage_telephony

pgaskin commented 6 years ago

Works for me.

pgaskin commented 6 years ago

@Sohamlad7 Are you planning to update cedric to Pie once LineageOS is updated?

Also, are you planning to release a new build of 15.1? I've been building it myself every 2 weeks (branch lineage-15.1-64) and it's been pretty stable (other than some delay starting the camera). The recent changes and additions in LineageOS have been pretty useful. Here is my latest build (using test-keys).

KalilDev commented 6 years ago

@geek1011 I'm the one maintaining Cedric RN. I made a treble build, but I've yet to make a non treble build. This is on hold until I finish making my common trees from scratch and unifying Cedric and Potter. if you want to check my work, look at my GitHub and at the Motorola-Common github

pgaskin commented 6 years ago

Thanks for the info. Your work looks good so far. As for treble, is it stable right now?

KalilDev commented 6 years ago

Only issues are camera not being able to record and the Moto actions app not being able to change settings on the fingerprint gestures. Both issues will be fixed with the Potter unification, and if it still doesn't work I'll fix it.

pgaskin commented 6 years ago

OK. I will probably try out treble. Do I just build and flash a build from the treble branch then flash a generic image over it? Also, what should the partition table look like?

Edit: Based on this and the output of cat /proc/partitions, it seems like you are using the oem partition (/dev/block/platform/soc/7824900.sdchi/by-name/oem -> /dev/mmcblk0p51) as the vendor partition for treble. Does it need to be formatted?

KalilDev commented 6 years ago

nope, block based zips overrides the entire partition to be exact down to the zeroes. if you want info on how to install you can check my XDA thread

pgaskin commented 6 years ago

OK, thanks. I completely missed that thread.