updated to use full path

SohoHouse / nuxt-oauth

Simple OAuth2 integration for your Nuxt app

MIT License

122 stars 27 forks source link

updated to use full path #31

Closed stabback closed 5 years ago

stabback commented 5 years ago

context.route.path does not include query params. Update to fullPath to redirect with query params.

stabback commented 5 years ago

@jerser commit message updated. The existing redirect test has been updated.

jerser commented 5 years ago

That doesn't test the actual bug explicitly though imho. I think there should be a test case that has a query string and that verifies it is not omitted.

stabback commented 5 years ago

@samtgarson Pinging on this

samtgarson commented 5 years ago

(PS: Would like to refactor at some point anyway to use passport, as we may need to support multiple auth providers in future... and it has massive community support)