search

Sohojoe / ActiveRagdollStyleTransfer

Research into locomotion style transfer with Active Ragdolls (using MarathonEnvs +ml_agents)
Apache License 2.0
143 stars 21 forks source link

tested for unity2019.1 and small improvement on installation #2

Open joanllobera opened 5 years ago

Sohojoe commented 5 years ago

Hi @joanllobera - thanks for this! its great to get a fresh set of eyes on the project and

I have couple of thoughts:

  1. unless there is a sepecific need for a new feature, it would be best to keep the unity version to the last LTS (at least while doing the update to latest ml-agents) - we've seen issues between Unity versions with regards to the physics (i.e. it can break the trained models)

  2. What about using pip install mlagents==0.5.0 to set the mlagents version?

joanllobera commented 5 years ago

hi, regarding your thoughts:

  1. I agree it is a good idea to stay with the latest LTS, this should mean Unity 2017.4.30, I believe? I will do all my tests with this version, until another LTS is released.

  2. I tested this install instruction you suggested, it seems to work OK. Maybe it is simpler to do it this way, whatever version of mlagents we finally use

joanllobera commented 5 years ago

sorry, correction, I will use 2018.4.4, it seems to also be LTS despite not appearing like this in unity hub.