SoilPulse / MetadataGenerator

The metadata generator guides researchers to the creation of reusable data sets in a webapp.
GNU General Public License v3.0
0 stars 0 forks source link

get full zenodo file api response #16

Closed jonaslenz closed 7 months ago

jonaslenz commented 7 months ago

currently only zip files are noticed while getting the file list from zenodo - changed to capture full response, but this might be needed to processed further

jandevaty commented 7 months ago

Which file/function should I review? The getFileListOfDOI/doi_files ? What does it mean? Should I check it and think about general solution, or is there some proposed solution which I missed?

jonaslenz commented 7 months ago

Hi Honza, I proposed allready changes in the resource_manager.py in the pull request: Can you see them there?

https://github.com/SoilPulse/MetadataGenerator/pull/16/commits/a37b83085fda705311579d2a60d57fcb3638b480

Cheers Jonas

Honza Devátý @.***> schrieb am Do., 25. Jan. 2024, 12:30:

Which file/function should I review? The getFileListOfDOI/doi_files ? What does it mean? Should I check it and think about general solution, or is there some proposed solution which I missed?

— Reply to this email directly, view it on GitHub https://github.com/SoilPulse/MetadataGenerator/pull/16#issuecomment-1909973017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJEBEWL5XHZHXUNIIWE5AH3YQI63XAVCNFSM6AAAAABCKIIQ6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE3TGMBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

jonaslenz commented 7 months ago

Hi Honza, I want to do less operations, so the response of e.g.:

https://zenodo.org/api/deposit/depositions/6654150/files

is not filtered for *.zip files, but returns the whole json response including all files and e.g. checksums. --> It is a question how much information we can and want store on the dataset.

jandevaty commented 7 months ago

OK, do whatever you like as long as get can somwhere a list of URLs to download :-D