Closed jonaslenz closed 2 months ago
Hi @jandevaty,
can you update the database/soilpulse.sql please, I tried to add the missing fields to make tests working again. But it is more straightforward, if you can simply push a new dump of the DB... Cheers Jonas
I commited and pushed it … though I think I already pushed it after last changes …
H9.
From: jonaslenz @.> Sent: Friday, August 30, 2024 1:53 PM To: SoilPulse/MetadataGenerator @.> Cc: Honza Devátý @.>; Mention @.> Subject: Re: [SoilPulse/MetadataGenerator] Table and Column container introduced ... implementation in progress (PR #41)
Hi @jandevatyhttps://github.com/jandevaty,
can you update the database/soilpulse.sql please, I tried to add the missing fields to make tests working again. But it is more straightforward, if you can simply push a new dump of the DB... Cheers Jonas
— Reply to this email directly, view it on GitHubhttps://github.com/SoilPulse/MetadataGenerator/pull/41#issuecomment-2320986798, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APMXNVCJ6OXYNHU33YPBCV3ZUBMKZAVCNFSM6AAAAABMZS5PV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQHE4DMNZZHA. You are receiving this because you were mentioned.Message ID: @.**@.>>
Codecov Report
Attention: Patch coverage is
70.00000%
with90 lines
in your changes missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== + Coverage 57.62% 62.40% +4.78% ========================================== Files 10 11 +1 Lines 2053 2184 +131 ========================================== + Hits 1183 1363 +180 + Misses 870 821 -49 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.