SoilPulse / MetadataGenerator

The metadata generator guides researchers to the creation of reusable data sets in a webapp.
GNU General Public License v3.0
0 stars 0 forks source link

Table and Column container introduced ... implementation in progress #41

Closed jonaslenz closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 70.00000% with 90 lines in your changes missing coverage. Please review.

Project coverage is 62.40%. Comparing base (409a192) to head (89abace). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/soilpulse/resource_managers/filesystem.py 63.08% 55 Missing :warning:
src/soilpulse/project_management.py 72.36% 21 Missing :warning:
src/soilpulse/resource_managers/data_structures.py 75.51% 12 Missing :warning:
src/soilpulse/db_access.py 81.81% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== + Coverage 57.62% 62.40% +4.78% ========================================== Files 10 11 +1 Lines 2053 2184 +131 ========================================== + Hits 1183 1363 +180 + Misses 870 821 -49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonaslenz commented 2 months ago

Hi @jandevaty,

can you update the database/soilpulse.sql please, I tried to add the missing fields to make tests working again. But it is more straightforward, if you can simply push a new dump of the DB... Cheers Jonas

jandevaty commented 2 months ago

I commited and pushed it … though I think I already pushed it after last changes …

H9.

From: jonaslenz @.> Sent: Friday, August 30, 2024 1:53 PM To: SoilPulse/MetadataGenerator @.> Cc: Honza Devátý @.>; Mention @.> Subject: Re: [SoilPulse/MetadataGenerator] Table and Column container introduced ... implementation in progress (PR #41)

Hi @jandevatyhttps://github.com/jandevaty,

can you update the database/soilpulse.sql please, I tried to add the missing fields to make tests working again. But it is more straightforward, if you can simply push a new dump of the DB... Cheers Jonas

— Reply to this email directly, view it on GitHubhttps://github.com/SoilPulse/MetadataGenerator/pull/41#issuecomment-2320986798, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APMXNVCJ6OXYNHU33YPBCV3ZUBMKZAVCNFSM6AAAAABMZS5PV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQHE4DMNZZHA. You are receiving this because you were mentioned.Message ID: @.**@.>>