Sokomine / mg_villages

villages for all mapgens (based on Nores mg)
24 stars 13 forks source link

Bug with Minetest 5.3.0 #29

Open AFCMS opened 3 years ago

AFCMS commented 3 years ago
AsyncErr: Lua: finishGenRuntime error from mod 'mg_villages' in callback environment_OnGenerated(): Unknown node: cottages:feldweg
stack traceback:
    [C]: in function 'get_content_id'
    ...\minetest-5.3.0-win64\bin\..\mods\mg_villages/mapgen.lua:916: in function 'place_villages_via_voxelmanip'
    ...\minetest-5.3.0-win64\bin\..\mods\mg_villages/mapgen.lua:1110: in function <...\minetest-5.3.0-win64\bin\..\mods\mg_villages/mapgen.lua:1065>
    ...ds\minetest-5.3.0-win64\bin\..\builtin\game\register.lua:429: in function <...ds\minetest-5.3.0-win64\bin\..\builtin\game\register.lua:413>
daretmavi commented 3 years ago

Got the same error.

2020-10-18 20:12:36: ERROR[Main]: ServerError: AsyncErr: Lua: finishGenRuntime error from mod 'mg_villages' in callback environment_OnGenerated(): Unknown node: cottages:feldweg
2020-10-18 20:12:36: ERROR[Main]: stack traceback:
2020-10-18 20:12:36: ERROR[Main]:   [C]: in function 'get_content_id'
2020-10-18 20:12:36: ERROR[Main]:   /home/user/.minetest/mods/mg_villages/mapgen.lua:918: in function 'place_villages_via_voxelmanip'
2020-10-18 20:12:36: ERROR[Main]:   /home/user/.minetest/mods/mg_villages/mapgen.lua:1112: in function </home/daret/.minetest/mods/mg_villages/mapgen.lua:1067>
2020-10-18 20:12:36: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:429: in function </usr/share/minetest/builtin/game/register.lua:413>

Looks like cottages (https://github.com/Sokomine/cottages) is a dependency.

SmallJoker commented 3 years ago
diff --git a/mapgen.lua b/mapgen.lua
index e1e0361..31d0677 100644
--- a/mapgen.lua
+++ b/mapgen.lua
@@ -915,10 +915,11 @@ mg_villages.place_villages_via_voxelmanip = function( villages, minp, maxp, vm,
                mg_villages.undo_mudflow( villages, {x=minp.x-3, y=minp.y, z=maxp.z-3}, {x=maxp.x+3, y=maxp.y, z=maxp.z+3}, vm, data, param2_data, a, village_area, cid)
        end

-       local c_feldweg =  minetest.get_content_id('cottages:feldweg');
-       if( not( c_feldweg )) then
-               c_feldweg = minetest.get_content_id('default:cobble');
+       local c_feldweg = 'cottages:feldweg'
+       if not minetest.registered_nodes[c_feldweg] then
+               c_feldweg = 'default:cobble'
        end
+       c_feldweg = minetest.get_content_id(c_feldweg)

        -- up til now, cid.c_water had to be default:water_source (or whatever the current
        -- game uses) so that the terrain could be adjusted; now, we may change it to
bnbwn commented 3 years ago

not sure if cottages as a dependency is required, but i added it, and added code above from joker and i'm good to go!

azharhamrat commented 1 year ago
diff --git a/mapgen.lua b/mapgen.lua
index e1e0361..31d0677 100644
--- a/mapgen.lua
+++ b/mapgen.lua
@@ -915,10 +915,11 @@ mg_villages.place_villages_via_voxelmanip = function( villages, minp, maxp, vm,
                mg_villages.undo_mudflow( villages, {x=minp.x-3, y=minp.y, z=maxp.z-3}, {x=maxp.x+3, y=maxp.y, z=maxp.z+3}, vm, data, param2_data, a, village_area, cid)
        end

-       local c_feldweg =  minetest.get_content_id('cottages:feldweg');
-       if( not( c_feldweg )) then
-               c_feldweg = minetest.get_content_id('default:cobble');
+       local c_feldweg = 'cottages:feldweg'
+       if not minetest.registered_nodes[c_feldweg] then
+               c_feldweg = 'default:cobble'
        end
+       c_feldweg = minetest.get_content_id(c_feldweg)

        -- up til now, cid.c_water had to be default:water_source (or whatever the current
        -- game uses) so that the terrain could be adjusted; now, we may change it to

nice work, solved the problem using Minetest 5.7.0 mapgen v7