Sokomine / travelnet

network of teleporter-boxes that allow easy travelling to other boxes on the same network (Mod for Minetest)
GNU General Public License v3.0
30 stars 52 forks source link

No longer allows updating of travelnets or assigning ownership (after Jan 2018) #27

Closed redblade7 closed 5 years ago

redblade7 commented 6 years ago

Hi,

After updating the mods on my server recently, I am unable to update travelnets with new stations. The station is added to the travelnet at that station only, other stations on the travelnet are not updated with the new stations when you punch them.

Also, I have an account which can add stations to other users' travelnets. This is no longer possible, and the new dialog's ownership field has absolutely no effect (it's always the user who placed the station).

The bug happened between January 15, 2018 and March 25, 2018.

Thank you!

redblade7 commented 6 years ago

Punching travelnets has no effect anymore

redblade7 commented 6 years ago

Some (but not all) stations have the move up/down options.

EDIT: After replacing stations, they have up/down options, but punching does not update the travelnet, you have to use up/down twice.

codexp commented 6 years ago

I confirm, there is a bug with updating travelnet boxes, punching them does not work anymore.

codexp commented 6 years ago

Why not placing an "Update" button on the form?

HybridDog commented 6 years ago

In my opinion boxes should be updated automatically.

codexp commented 6 years ago

I believe there is a config for enabling automatic update of boxes, but it uses abm.

codexp commented 6 years ago

I've figured out why punching does not work. This happens in creative mode when not wielding with axe or shovel (update works with those). But if you have bare hands or hold anything else (except pickaxe), this results in tool_capabilities["groupcaps"]["cracky"] having a table with this values:

{
    times = {
        42,
        42,
        42
    },
    uses = 0,
    maxlevel = 256
}

thus the travelnet.check_if_trying_to_dig function returns falsely TRUE.

redblade7 commented 6 years ago

I can confirm that it only affects my creative server (Creative Gardens) and using the axe works properly. Don't have time right now to check the shovel or pickaxe.

I tried the ABM last night but other players complained of being occasionally flooded with messages about it.

Sokomine commented 5 years ago

There have been issues with distinguishing between punching and digging - in particular regarding creative mode. For a while, a diamond pick was necessary to dig the stations. However, the users did not like this option.

The current solution is a "Remove station" button. Punching updates the station, and clicking on that button digs it and places it into your inventory.

I've also fixed a bug with attaching travelnets to nets of other players not working anymore.

Sokomine commented 5 years ago

The bugs ought to be fixed. Please don't hesistate to open a new issue if any new errors or bugs occour or anything ought to be changed in the newest version.