Open Poikilos opened 5 years ago
Here are the additional improvements done today in full for 2019-08-08 (c8767ef):
S("Network '%s',"):format(network_name).." "..
S("already contains the maximum number (=%s) of allowed stations per network. "..
"Please choose a different/new network name."):format(travelnet.MAX_STATIONS_PER_NETWORK));
into one string, since not all languages have same sentence structure (and having a comma after the subject is not correct english grammar). The structure issue also applies to "Station '%s'"
:
"has been REMOVED from the network '%s'."
(changed to "Station '%s' disconnected from network '%s'."
)"does not exist (anymore?) on this network."
(changed to include Station '%s'
)"on travelnet '%s'"
and "is ready. Right-click to travel, punch to update."
"has been added to the network '%s'"
and ", which now consists of %s station(s)."
(combined to become "Station '%s' connected to network '%s'"
... ", which now consists of %s station(s)."
)Here are the additional improvements done today in full for 2019-08-08 (c8767ef):
- Correct po files to match template.pot
- Make line breaking the same in each file for string continuations.
- "Savefile '%s' was not found." to "Savefile '%s' does not exist."
- "allows attaching" to "Allow attaching" ... "."
- "allows breaking" to "Allow removing" ... "."
- "Resetting...." to "Changes reverted."
...
Everything looks good! 👍 I submitted a review to fix some other issues in the translations.
You can resolve all the other conversations.
Also, change from passive to active voice when reasonable, to sound less ambiguous and less boring. Also, remove trailing spaces to prevent trivial diff entries on later PRs due to editors removing them automatically.