search

SokyranTheDragon / Minor-Integrations-and-Additions-MIA-

A Minecraft modification adding integrations between mods and some small features
https://www.curseforge.com/minecraft/mc-mods/minor-integrations-and-additions-mia
MIT License
7 stars 3 forks source link

Music player continues to play music if the item is moved to a container or anything else with a GUI #8

Closed aking4125 closed 4 years ago

aking4125 commented 4 years ago

Best way to explain it, is to the insert a music disc into the music player. Then place the music player item into say, a chest. The music will keep playing. Worse yet, you can actually void the item by say, moving it to a trash bin.

If you get a new music player to play a new track, it just plays both tracks simultaneously. The only way to stop it is to log out of the Single player world or server. There is no other way that I found to stop that.

This could be a potential issue if, say there was a block or item that just takes the item out of a players inventory by accident somehow or if the player moves the music player to, say a trash bin by mistake.

SokyranTheDragon commented 4 years ago

Hmm... That's strange. I was pretty sure I made sure it couldn't happen. Well, I guess I'll have to look into that then.

SokyranTheDragon commented 4 years ago

Oh, I think I see where the issue is. When a rather serious bug I had to change the music player a bit, and seems like I forgot to include the part responsible for checking played songs without music player in the inventory. Should be fixed soon.

aking4125 commented 4 years ago

Copy that. No worries at all.

SokyranTheDragon commented 4 years ago

It was slightly delayed due to a small issue that popped up after fixing this, but the fix should be up really soon.

aking4125 commented 4 years ago

Yep this seemed to have completely fixed it. Thank you for the quick response!