search

SolDoesTech / HyprV4

497 stars 142 forks source link

sed on /etc/mkinitcpio.conf #21

Open Mickhat opened 1 year ago

Mickhat commented 1 year ago

https://github.com/SolDoesTech/HyprV4/blob/7550b4c36167e8ff3c67f7b790a7003cbb3e649e/set-hypr#L230

This should be changed to sudo sed -i 's/MODULES=""/MODULES=(nvidia nvidia_modeset nvidia_uvm nvidia_drm)/' /etc/mkinitcpio.conf

Otherwise the correct values will never be written to the file.

goteksc commented 1 year ago

on archlinux /etc/mkinitcpio.conf comes with MODULES=(), so the line is correct.

I have a different suggestion though: sudo sed -i 's/MODULES=(/MODULES=(nvidia nvidia_modeset nvidia_uvm nvidia_drm /' /etc/mkinitcpio.conf

Note the missing closed paren in the first section, and the extra whitespace at the end of the second section. This will preserve whatever was in the modules list beforehand. I had to take care of this for use with btrfs on root.