search

SolaceDev / solace-dev-tutorials

Repo for Solace Tutorials. Located at tutorials.solace.dev
MIT License
7 stars 8 forks source link

Added prototype for TOC #133

Closed TamimiGitHub closed 1 year ago

TamimiGitHub commented 1 year ago

Thanks for the PR @blainehussey ! I will be reviewing and see if we have any further comments on it. If all looks good we'll be good to merge!

TamimiGitHub commented 1 year ago

Looks good to me! Will keep the PR up for a bit to see if @Mrc0113 has any other comments. I recall there were some comments on the contrast of the active page/header on the navigation. Otherwise, I do not have any other comments

blainehussey commented 1 year ago

Thanks @TamimiGitHub, I think we should go ahead and merge this without worrying much on the background colour for the sidebar navigations, as it's also the same style we're also using on the What is EDA page on solace.com. If we decide to make tweaks to the colours or small things once it's on PROD, we can just create a new separate PR. Looks like merging is blocked, assuming this needs to be reviewed, let me know if I should just select "Merge without waiting for requirements to be met".

Also is the link checker working properly, it's still showing that it's waiting for status to be reported but it's bee a while.

Thanks again.