SolaceProducts / pubsubplus-kubernetes-quickstart

Quickstart to launch a Solace PubSub+ Software Event Broker in Kubernetes using Operator
Apache License 2.0
5 stars 2 forks source link

[Bug]: Operator does not perform upgrades on the prometheus-exporter #83

Closed JanGrosse closed 1 month ago

JanGrosse commented 4 months ago

Bug Description

Hi everyone, I think I faced a potential bug regarding upgrades towards the prometheus-exporter. A small testing deployment with the file initial-deployment.yaml

apiVersion: pubsubplus.solace.com/v1beta1
kind: PubSubPlusEventBroker
metadata:
  name: dev-example
spec:
  developer: true
  monitoring:
    enabled: true
    image:
      repository: solacecommunity/solace-prometheus-exporter
      tag: v1.4.12

After the initial deployment I can see my prometheus-exporter running in v1.4.12 as specified in the initial file. Now, after I edit the tag and increase the version to the next higher one (in this case v1.5.0) and reapply the file

apiVersion: pubsubplus.solace.com/v1beta1
kind: PubSubPlusEventBroker
metadata:
  name: dev-example
spec:
  developer: true
  monitoring:
    enabled: true
    image:
      repository: solacecommunity/solace-prometheus-exporter
      tag: v1.5.0

Just nothing happens. I thought maybe the reconcilation loop might be longer on the exporter so I gave it a night of sleep, but still in the next morning the version stayed unchanged.

Expected Behavior

I expected that a increased tag version would cause a upgrade on the prometheus-exporter. I checked in the operational guides for limitations, but did not find one which specified that we can not update the exporter itself (see here update limitations).

Steps to Reproduce

See in the bug description.

Solace Broker version

Latest

Solace API

none

Solace API version

none

LewisKSaint commented 4 months ago

Thanks for flagging this @JanGrosse, it was intentional to not watch changes of the Prometheus Exporter in the current release of the Operator. You are also right, It should have been included in the update limitations.

LewisKSaint commented 1 month ago

As part of version 1.1.1, this update has been implemented. Please test the new changes and share your feedback