search

Solaestas / Everglow

GNU General Public License v3.0
28 stars 4 forks source link

Merge VortexVanquisher Branch to Old Master Branch #144

Closed Setnour6 closed 1 year ago

Setnour6 commented 1 year ago

This PR adds changes made to the Vortex Vanquisher weapon to the old version of the master branch. Changes can be ported from the vortex vanquisher branch to the custom build branch as an alternative option.

Solaestas commented 1 year ago

In fact, all old changes will be merged into the master directly, so there is no need to remain the old master

Solaestas commented 1 year ago

I mean, just commit the old changes like new changes, instead of creating the pr to the master-old

Setnour6 commented 1 year ago

In fact, all old changes will be merged into the master directly, so there is no need to remain the old master

The custom build branch relies on an external program (in this case, tModSources) in order for Everglow's custom build to run. Not everyone will have access to the mod, because the build will fail from the missing dependencies that tModSources provides.

Solaestas commented 1 year ago

In fact, all old changes will be merged into the master directly, so there is no need to remain the old master

The custom build branch relies on an external program (in this case, tModSources) in order for Everglow's custom build to run. Not everyone will have access to the mod, because the build will fail from the missing dependencies that tModSources provides.

So you want to keep the old master for others to download? But the master will no longer receive update.

Setnour6 commented 1 year ago

So you want to keep the old master for others to download? But the master will no longer receive update.

Yes. We will never know what happens to the 1.4.4 version of tModLoader, say if the updates make syncing the branches to the version very difficult because of some changes that happen. The old master branch does not need or rely on another program to make Everglow work there.

Solaestas commented 1 year ago

So you want to keep the old master for others to download? But the master will no longer receive update.

Yes. We will never know what happens to the 1.4.4 version of tModLoader, say if the updates make syncing the branches to the version very difficult because of some changes that happen. The old master branch does not need or rely on another program to make Everglow work there.

OK, I understand