Solaestas / Everglow

GNU General Public License v3.0
28 stars 4 forks source link

Hotfix/reuse sublib #174

Closed Omnielement closed 1 year ago

Omnielement commented 1 year ago

reuse sublib

Omnielement commented 1 year ago

The firefly pylon does not appear, the MothWorldDoor tile and FireflyCapital item does not work, and the Yggdrasil Kelp Background music does not play. There is also an issue where after a world is finished being created, a black screen appears with the text "Validating World Save: 100%" and you get stuck. See issue #179 for more information.

They need to be fixed.

Something was needed in the firefly tile hotfix,and I'll fix the rest part of these bug soon.

Omnielement commented 1 year ago

The firefly pylon does not appear, the MothWorldDoor tile and FireflyCapital item does not work, and the Yggdrasil Kelp Background music does not play. There is also an issue where after a world is finished being created, a black screen appears with the text "Validating World Save: 100%" and you get stuck. See issue #179 for more information.

They need to be fixed.

fixed

Omnielement commented 1 year ago

3. orld through the moth world door (or firefly capital/impression item).

Yggdrasil Subworld

The field "ShouldSave" in the SubWorld class, if true, will lead to crash when creating new world.(Sublib should be blame in this case).And, if false, all block changes will not save when leaving the subWorld.

Setnour6 commented 1 year ago
  1. orld through the moth world door (or firefly capital/impression item).

    Yggdrasil Subworld

The field "ShouldSave" in the SubWorld class, if true, will lead to crash when creating new world.(Sublib should be blame in this case).And, if false, all block changes will not save when leaving the subWorld.

Oh okay. I thought that it was fixed but it was still set to false. So for now it is okay that the subworld does not save. However, the main world should not reset, and the main world resetting should be fixed (unless it is also part of the ShouldSave crash issue).