search

Solaestas / Everglow

GNU General Public License v3.0
27 stars 4 forks source link

Minortopography/genpass #216

Closed Omnielement closed 11 months ago

Omnielement commented 11 months ago

add giant pine tree

Omnielement commented 11 months ago

@Setnour6 What are you doing in IcedSpear(Projectile)? "Collide" is using to detect NPC, it's not a vanilla method.

Setnour6 commented 11 months ago

@Setnour6 What are you doing in IcedSpear(Projectile)? "Collide" is using to detect NPC, it's not a vanilla method.

There is an issue when I point the spear to the ground on a lower surface area and the spear is touching the ground. I wanted to fix that. dotnet_IFbqBr1ifX

Omnielement commented 11 months ago

@Setnour6 What are you doing in IcedSpear(Projectile)? "Collide" is using to detect NPC, it's not a vanilla method.

There is an issue when I point the spear to the ground on a lower surface area and the spear is touching the ground. I wanted to fix that. dotnet_IFbqBr1ifX

Can it still stick to the target normally now?

Setnour6 commented 11 months ago

Can it still stick to the target normally now?

It looks like it can dotnet_udZ0dNiZQ3

Omnielement commented 11 months ago

Can it still stick to the target normally now?

It looks like it can dotnet_udZ0dNiZQ3

I apologize, I was misunderstood your code.Everything was well, you can revert the "undo".

Setnour6 commented 11 months ago

I apologize, I was misunderstood your code.Everything was well, you can revert the "undo".

That is okay. I know you wanted the collision functions to work properly and I do too

Setnour6 commented 11 months ago

I tested it. The last thing that needs to change is the sunglow chandelier animation not working, and that's it.

https://github.com/Solaestas/Everglow/assets/70764728/abf1804d-3f3c-4dca-9d56-57903852ee75

Also, is the pine sprite supposed to attack enemies or does it just hover over them to highlight them?

Omnielement commented 11 months ago

this branch still very important after this merge