search

Solaestas / Everglow

GNU General Public License v3.0
26 stars 3 forks source link

Shield of Vortex vanquisher #248

Closed Felixyang777 closed 4 months ago

Felixyang777 commented 4 months ago

The shield display has been completed. Since the code is directly modified from the vanilla code, it can be a bit unappetizing.

lace-wing commented 4 months ago

Keeping the shield value/percentage display out of the health bar would be better: to modify the health bar means potential conflicts with other mods which also mess it around. Doesn't even need to be a 'bar', something like the spellbook ring behind the player seems more desirable. Showing cracks on the shield or dimming it maybe?

Felixyang777 commented 4 months ago

Keeping the shield value/percentage display out of the health bar would be better: to modify the health bar means potential conflicts with other mods which also mess it around. Doesn't even need to be a 'bar', something like the spellbook ring behind the player seems more desirable. Showing cracks on the shield or dimming it maybe?

Actually I dont think the bar over lifebar is necessary .In addition to the reasons you’ve said, it also because it may affect players‘ judgment of their life，but Omni insisted on it.

shb201902040125 commented 4 months ago

Keeping the shield value/percentage display out of the health bar would be better: to modify the health bar means potential conflicts with other mods which also mess it around. Doesn't even need to be a 'bar', something like the spellbook ring behind the player seems more desirable. Showing cracks on the shield or dimming it maybe?

Actually I dont think the bar over lifebar is necessary .In addition to the reasons you’ve said, it also because it may affect players‘ judgment of their life，but Omni insisted on it.

I think the biggest problem is that your shield value is gold color and the player's life is gold too

Felixyang777 commented 4 months ago

Keeping the shield value/percentage display out of the health bar would be better: to modify the health bar means potential conflicts with other mods which also mess it around. Doesn't even need to be a 'bar', something like the spellbook ring behind the player seems more desirable. Showing cracks on the shield or dimming it maybe?

Actually I dont think the bar over lifebar is necessary .In addition to the reasons you’ve said, it also because it may affect players‘ judgment of their life，but Omni insisted on it.

I think the biggest problem is that your shield value is gold color and the player's life is gold too

That's what I mean

Setnour6 commented 4 months ago

Keeping the shield value/percentage display out of the health bar would be better: to modify the health bar means potential conflicts with other mods which also mess it around. Doesn't even need to be a 'bar', something like the spellbook ring behind the player seems more desirable. Showing cracks on the shield or dimming it maybe?

Actually I dont think the bar over lifebar is necessary .In addition to the reasons you’ve said, it also because it may affect players‘ judgment of their life，but Omni insisted on it.

Sorry for the late response. You could make a config entry for the health overlay and add a bar beside the player for the amount of time (and shield health) the shield will stay active for before it disappears.