Solaestas / Everglow

GNU General Public License v3.0
28 stars 4 forks source link

HJSON File Separation #42

Open lace-wing opened 1 year ago

lace-wing commented 1 year ago

Waiting for Major Localization Changes to be completed.

To make localization files more readable and avoid conflicts, the .hjson files are to be separated according to modules they are targeting at. For example, the file en-US.hjson will be separated into each module, and the key inside will be changed:

Before
Master: Resources/Localization/en-US.hjsn
Mods :
{
    Everglow :
    {
        ItemName :
        {
            AnItem : "Name of This Item"
        }
    }
}
After
Yggdrasil_loc: Resources/Localization/Yggdrasil/en-US.hjson
Mods :
{
    Everglow :
    {
        Yggdrasil :
        {
            ItemName :
            {
                AnItem : "Name of This Item"
            }
        }
    }
}

Reminder: when tML's localization overhual is done, the keys need to be changed

Setnour6 commented 1 year ago

I like the idea, organizing the localizations to different places for more module customizability (whether a module is enabled or disabled, and having their own localization files there for conflict reduction like you said earlier).

We could make a branch called localization-separation for this process, then merge it to the localization branch itself.

lace-wing commented 1 year ago

I will do that after my real life stuffs are settled, but you can start first if you know how to do.

Setnour6 commented 1 year ago

The major localization changes PR has been merged to 1.4.4. Do note that the 1.4.4 test branch is on the repository already, so you can test the changes (fixing errors and rebuilding as necessary via tModPorter) when you have time. I’ll also see if I can test changes as well when I get the chance