proposal for addiing SPL Token Swap dapp built using solana

[shivamSspirit]

this dapp describes how we can utilize spl-token swap program to build a dapp that handles

1. depositing liquidity to the pool
2. withdrawing your deposited liquidity
3. swapping from one token to the other

https://github.com/shivamsoni00/token-swap this is my repo for this example project

[buffalojoec]

Hey, this is awesome! Thank you for proposing this.

I'll pull this down and have a look, but at first glance it looks great.

Give me a workshop title for it - like "SPL Token Swap" instead of calling it an "example" and we should be good to go. Update the title in the README as well.

I'll circle back with any feedback later on once I've had a chance to pull it down.

Thanks mate!

[buffalojoec]

I noticed your workshop is using the swap program "maintained by Serum" - did you mean OpenBook? If it is a Serum program still, we should probably move away from that, since Serum is no longer maintaining it. We don't want to give people the wrong idea.

I think you did a nice job with a cool UI and you explain the different accounts and instructions in the README pretty well, however I have a few requests:

• Give an overview at the beginning of how a swap actually works. Talk about how the amounts are calculated and whatever else is relevant to the swap workshop itself.
  • Link out any relevant resources for DeFi, swapping, SPL Tokens, etc.
• Explain where to find this program (not the Serum one), and cover some of really important blocks of code that are going to handle the swap in your demo.
  • Ideally it's important as part of this workshop to cover the program so people know how swapping actually works under the hood, how it looks in Rust, how production-grade swap/DeFi programs look, etc.
• Reference the file names (and - where relevant - the line numbers) for the code snippets you've included in the README.
• Please check your README for capitalization and other grammatical errors, and use Grammarly or ChatGPT if necessary. It's important that your content is easy to consume

Also, according to the grant posting on Superteam's board, the deliverables are as follows:

1. A fully functional application built on Solana that demonstrates the ability to interact with the Solana blockchain.
2. All source code for the application, written in a professional manner with clear documentation committed to https://github.com/Solana-Workshops.
3. A detailed README file that explains how to set up and run the application.
4. A technical workshop that teaches participants how to build the application deployed to Solana Playground (https://beta.solpg.io/tutorials).
5. All workshop materials, including presentation slides, code examples, and any other necessary materials.

You've got 1, 2, 3 and 5 in your repository, but in regards to #4:

You cannot host websites on Solana Playground, but you can host client-side JavaScript code. What's your plan for adding this workshop to their collection?

[buffalojoec]

Hey @shivamsoni00 I'm going to close this if there's no activity by Friday!