Solar-Helix-Independent-Transport / allianceauth-discordbot

allianceauth-discordbot
MIT License
6 stars 19 forks source link

requirements for python redis are still specified as <5.0.0 #88

Closed aixtools closed 4 months ago

aixtools commented 4 months ago

In the pyprojects.yaml file the requirements still state that the python redis module must be <5.0.0.

Is this still a requirement?

IMPACT: if it is I'll likely need to remove package and either use internal discord interface, or someone elses module (and i hate changing setups :p)

thx for all your development fot aa!!

soratidus999 commented 4 months ago

redis-py 5.0 is still pretty new, curious what this is holding you back from. iirc the upstream issue in aioredis is fixed now

aixtools commented 4 months ago

There are new checks being performed with v4 - and it seems that is more on the redis-server than py-redis (now that I have been doing more research) - but managing two AUTH servers - one using this app, one not - I prefer to have both at the same levels of python packages.

TLDR: the key issues are comfort and confusion (that two sites report):

But, iirc, py-redis-v5 has been out there for about a year, because I have been ignoring the message for quite awhile. It is the extra checks being done by AUTH for redis-server (but just calling it redis and having py-redis at v4.x or v5.x while it is redis-v6.x that is EOL. when you are really interested in redis all these numbers do is distract and detract from the feeling of being in sync, whatever.

Guess I just have to continue ignoring it, and hope AUTH doesn´t start demanding pv-redis-v5. :)

aixtools commented 4 months ago

redis-py just updated to 5.0.8 - hoping that is old enough to at least warrant a test that everything still works.

What I see when updating:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
allianceauth-discordbot 3.8.0 requires redis<5.0.0,>=4.2.0, but you have redis 5.0.8 which is incompatible.

so I then run: pip install -U "redis<5.0.0,>=4.2.0" to make pip happy again.

pvyParts commented 4 months ago

fixed in 3.8.1