SolarArbiter / solarforecastarbiter-api

HTTP API and database schema for the Solar Forecast Arbiter
https://api.solarforecastarbiter.org
MIT License
10 stars 6 forks source link

Add update permission to user during CDF group/report creation #182

Closed alorenzo175 closed 4 years ago

alorenzo175 commented 4 years ago

closes #171

alorenzo175 commented 4 years ago

Currently too difficult to test storage_interface/the api endpoints for the change since the user already has update permissions on everything. The mysql tests should be sufficient though.

alorenzo175 commented 4 years ago

Do you mean to avoid roles with the same name? Right now the role name is UNIQUE so mysql won't let that happen.

lboeman commented 4 years ago

Yeah, I was thinking of the potential to create some role with a matching name, and have it automatically updated with permissions. Taking another look at the workflow we have, it should never update a user that is not actively assigned a Default user role <user_id> and thus, in the organization. So I think my concerns are already adequately addressed :+1: