search

SolarArbiter / solarforecastarbiter-api

HTTP API and database schema for the Solar Forecast Arbiter
https://api.solarforecastarbiter.org
MIT License
10 stars 6 forks source link

Improve Report Validation #279

Closed lboeman closed 3 years ago

lboeman commented 3 years ago

Trying to tackle a few issues related to Report Validation: closes #193 - Primary part of this PR. closes #79 - The remaining point in this issue is to providing missing/defaults to remaining report fields.

147 - While working with the schema, it's probably worthwhile to improve on the API documentation related to reports.

lboeman commented 3 years ago

I think this is ready for a review. Should the API reject object pairs with a forecast_type of probabilistic_forecast that have a reference forecast?

wholmgren commented 3 years ago

We're going to add a CRPS skill score soon so I don't think it's worth putting in the effort to reject probabilistic forecasts that have a reference forecast.

lboeman commented 3 years ago

We're going to add a CRPS skill score soon so I don't think it's worth putting in the effort to reject probabilistic forecasts that have a reference forecast.

Are there any further restrictions on probabilistic forecast groups? In this PR, I've only checked matching variable, site or aggregate, interval_length, interval_label and axis.