Handle permission failure when reading report values

SolarArbiter / solarforecastarbiter-api

HTTP API and database schema for the Solar Forecast Arbiter

https://api.solarforecastarbiter.org

MIT License

10 stars 6 forks source link

Handle permission failure when reading report values #280

Closed lboeman closed 3 years ago

lboeman commented 3 years ago

To support viewing a report with only read permissions on the report(https://github.com/SolarArbiter/solarforecastarbiter-dashboard/issues/134). Just handles the StorageAuthError that is raised when a user does not have read_values and returns an empty list. @alorenzo175 Do you think this needs anything else? Any possible issues with core?

alorenzo175 commented 3 years ago

I don't think it will cause an issue. Should maybe test w/ a report on dev

lboeman commented 3 years ago

I created a new org and test report and shared it with testing@solarforecastarbiter.org to verify this isn't going to fail on dev: https://dev-dashboard.solarforecastarbiter.org/reports/9fa91366-0a76-11eb-92e3-0a580a800215. OK to merge? Without the dashboard PR, it should just produce empty timeseries/scatter plots.