search

SolarArbiter / solarforecastarbiter-api

HTTP API and database schema for the Solar Forecast Arbiter
https://api.solarforecastarbiter.org
MIT License
10 stars 6 forks source link

add report_parameters.timezone #313

Closed wholmgren closed 3 years ago

wholmgren commented 3 years ago

supports https://github.com/SolarArbiter/solarforecastarbiter-core/pull/681

wholmgren commented 3 years ago

A timezone parameter will need to be added to the fixture here:

I believe this is no longer necessary/desired given the default/missing parameters. Adding it caused a few tests to fail, while removing it made the tests pass again. Also the other optional parameter, forecast fill method, isn't included in that fixture.

Looks to me like the test python37 failure is unrelated. And not sure why codecov is complaining since it says the diff is fully covered.

wholmgren commented 3 years ago

@alorenzo175 any concerns with this or the related core PR?

alorenzo175 commented 3 years ago

Nope, no concerns from me. I would just make sure to make a report now on dev (with no timezone specified) and make sure it still works after merging this and core (without wiping the dev db). This will hopefully catch any issues that could affect the prod reports.

wholmgren commented 3 years ago

thanks!