Closed wholmgren closed 4 years ago
Add reference forecast information to reports/templates/metrics_meta_table.html, obsfx_table.html, or a new table. If we put it in the metrics_meta_table, the new column would probably just contain the name (with link) or None. The obsfx_table would make sense to be clear about the resampling/alignment (or lack thereof). But I don't know if we can cram more into that table.
Do we really need the interval label/length for the observation and forecast in the obsfx_table when we provide the links to the metadata? It would free up space for a reference forecast column. Alternatively move the interval information to another table
https://github.com/SolarArbiter/solarforecastarbiter_dashboard/issues/214 discussed the need to implement reference forecast metrics on a per observation/forecast basis rather than a single reference forecast for all observation/forecasts. Most relevant part is quoted below:
It appears we need to do the following in core:
reports.get_data_for_report
needs to get data for reference forecasts just like any other forecast.preprocessing.process_forecast_observations
to handle the reference forecast data and assign it toProcessedForecastObservation.reference_forecast_values
. It appears thatProcessedForecastObservation.reference_forecast_values
is not currently used anywhere in the code.ref_pair
/ref_fx_obs
kwargs fromcalculator.calculate_metrics
,calculator.calculate_deterministic_metrics
, andcalculate_probabilistic_metrics
. Modify these functions to look up the right data from theprocessed_fx_obs
instead. ~Also event metrics pending #361.~ (nevermind... we don't have any skill metrics for events.)reports/templates/metrics_meta_table.html
,obsfx_table.html
, or a new table. If we put it in themetrics_meta_table
, the new column would probably just contain the name (with link) orNone
. Theobsfx_table
would make sense to be clear about the resampling/alignment (or lack thereof). But I don't know if we can cram more into that table.https://github.com/SolarArbiter/solarforecastarbiter_dashboard/pull/220 implements the dashboard front end for this, including a new
reference_forecast
key underobject_pairs
in the report's json specification.