Open williamhobbs opened 2 years ago
From a quick glance, it seems reasonable to add those arguments to cli.fetchnwp
and propagate them down through io.fetch.nwp.run
and helper functions.
Considerations:
reference_observations.py
uses the default DOMAIN
as a check when creating reference forecasts, but I think that potential inconsistency can be ignored.I suppose another option is reading from environment variables e.g.
DOMAIN = {'subregion': '',
'leftlon': os.environ.get('SFA_DOMAIN_LEFTLON', -90.5),
'rightlon': -80.5, # and so on...
'toplat': 35.2,
'bottomlat': 30}
To significantly reduce NWP file sizes, I've been modifying the DOMAIN in /solarforecastarbiter/io/nwp.py, e.g., for a region in the Southeast:
Maybe there's a better way to do this, but if not, would it make sense to allow a custom domain to be defined through the command line interface as an option for fetchnwp?
Similar, but maybe less useful, would be the ability to define an upper limit on the valid hour for a model. For example, if someone wants to use the GEFS for a probabilistic forecast, but they are not interested in forecasting beyond 24 hours, they could avoid having to save data for hours 30-384 (or whatever the relevant intervals are for GEFS).