search

SolarArbiter / solarforecastarbiter-core

Core data gathering, validation, processing, and reporting package for the Solar Forecast Arbiter
https://solarforecastarbiter-core.readthedocs.io
MIT License
33 stars 21 forks source link

`filter_resample` uses `>` instead of `>=` when comparing against flag resample thresholds #723

Closed wholmgren closed 2 years ago

wholmgren commented 2 years ago

The great preprocessing refactor (#580) mistakenly changed the comparison of number of bad data points against the threshold from >= to >.

Previous:

https://github.com/SolarArbiter/solarforecastarbiter-core/pull/580/files#diff-3738afa2f44ae4378b4e0e68a3b6b14ba99bfe5965cf6f0f4e8158ce023b9c8aL238-L240

New:

https://github.com/SolarArbiter/solarforecastarbiter-core/pull/580/files#diff-3738afa2f44ae4378b4e0e68a3b6b14ba99bfe5965cf6f0f4e8158ce023b9c8aR372

First identified in https://github.com/SolarArbiter/SolarArbiter.github.io/pull/201#discussion_r696888487