search

SolarArbiter / solarforecastarbiter-core

Core data gathering, validation, processing, and reporting package for the Solar Forecast Arbiter
https://solarforecastarbiter-core.readthedocs.io
MIT License
33 stars 21 forks source link

unused argument `dni_extra` in `check_irradiance_consistency_QCRad` #733

Closed wholmgren closed 2 years ago

wholmgren commented 3 years ago

I don't recall if there was ever an API consistency reason for the unused dni_extra argument in check_irradiance_consistency_QCRad or if it was just a mistake, but it looks to me like we can remove it.

https://github.com/SolarArbiter/solarforecastarbiter-core/blob/f3d3f6267c482abbde709c81926857f4ad414460/solarforecastarbiter/validation/validator.py#L272-L273

The corresponding pvanalytics function dropped the argument.

https://github.com/pvlib/pvanalytics/blob/a3d3860ee848afd5cb7184b36beedcd14dbbdc60/pvanalytics/quality/irradiance.py#L285-L286