SolarArbiter / solarforecastarbiter-core

Core data gathering, validation, processing, and reporting package for the Solar Forecast Arbiter
https://solarforecastarbiter-core.readthedocs.io
MIT License
33 stars 21 forks source link

Update nwp.py #794

Open williamhobbs opened 1 year ago

williamhobbs commented 1 year ago

The current NWP fetch process only grabs HRRR (hourly) out to 36 hours (for cycles where it goes out more than 18 hours), but HRRR has forecasts out to 48 hours (https://github.com/SolarArbiter/solarforecastarbiter-core/issues/793). This addresses that issue.

I would have also addressed the issue with RAP going out to 51 hours for some cycles, but I have not been able to successfully fetch RAP NWP files to test it (see https://github.com/SolarArbiter/solarforecastarbiter-core/issues/699), so I ignored that one.

I did run some quick tests with the changes to HRRR and I was able to successfully fetch and process grib files out to 48 hours for the relevant cycles. Someone let me know if documentation of that is needed. Similarly, I'm not sure what is needed for the checklist above, so let me know if I need to take other steps for tests, documentation, etc.

dplarson commented 1 year ago

Thanks @williamhobbs. I'll start reviewing and can follow-up with any revisions needed, including what's needed for the checklist above.