SolarArbiter / solarforecastarbiter-dashboard

Templates and code for rendering the Solar Forecast Arbiter dashboard.
https://dashboard.solarforecastarbiter.org
MIT License
9 stars 6 forks source link

Report javascript error for probabilistic forecasts #300

Closed alorenzo175 closed 4 years ago

alorenzo175 commented 4 years ago

image

alorenzo175 commented 4 years ago

And the CRPS drop downs don't work, maybe related?

alorenzo175 commented 4 years ago

from https://dev-dashboard.solarforecastarbiter.org/reports/60f746a8-b7f7-11ea-b06d-0a580a8200f2, but no guarantees if database is wiped

lboeman commented 4 years ago

Just so it doesn't get lost, cause of the error is using the forecast names directly, and special characters are being escaped with HTML codes, causing invalid selectors. e.g. #year_bs_Albuquerque_NM_Day_Ahead_GEFS_ac_power_Prob(f_<=_x)_=_10.0%

wholmgren commented 4 years ago

Should we instead modify the core templating so that problematic ids are not created? Probably just a matter of adding replace('<=', 'lte') where the ids are created. Not sure if /, ^, %, = would also cause problems.

lboeman commented 4 years ago

Should we instead modify the core templating so that problematic ids are not created? Probably just a matter of adding replace('<=', 'lte') where the ids are created. Not sure if /, ^, %, = would also cause problems.

That's probably the way to go. I haven't touched the code that utilizes the ids in a minute, but it might require some work to maintain relationships between an object's actual name and the cleaned id-safe version.