search

SolarBear / Numenera-FoundryVTT

Numenera support for the Foundry virtual tabletop
MIT License
28 stars 20 forks source link

Roll against level 0 task always fails #177

Closed snorith closed 3 years ago

snorith commented 3 years ago

If you use the Effort dialog and modify the task level to zero, and then choose to roll, it will always fail despite rolling higher than zero, and not rolling a critical fail.

Capto_Capture 2021-02-28_12-13-42_PM
SolarBear commented 3 years ago

Weird! This should obviously be an automatic success... Thanks for the report

snorith commented 3 years ago

I think that it might have something to do with the formula not being valid -- but I could be wrong.

SolarBear commented 3 years ago

No, you're absolutely right: I'm not quite sure if it's the intended behavior but I did a simple test: I just typed in /roll {1d2}>=0 and the roll is always a failure.

That might be an overlooked edge case with Foundry dice rolling parser (who the heck would compare against zero?) but I can easily work around that problem.

SolarBear commented 3 years ago

Will be fixed in 1.4.3

SolarBear commented 3 years ago

Just released the fix with version 1.4.3