SolarEdgeTech / pyctuator

Monitor Python applications using Spring Boot Admin
Apache License 2.0
175 stars 18 forks source link

Health indictor should return 503 when status is DOWN #83

Closed michaelyaakoby closed 2 years ago

michaelyaakoby commented 2 years ago

Fix #79

codecov-commenter commented 2 years ago

Codecov Report

Base: 95.02% // Head: 95.13% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (338325f) compared to base (504ccb3). Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #83 +/- ## ========================================== + Coverage 95.02% 95.13% +0.10% ========================================== Files 28 28 Lines 1106 1151 +45 ========================================== + Hits 1051 1095 +44 - Misses 55 56 +1 ``` | [Impacted Files](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [pyctuator/health/db\_health\_provider.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2hlYWx0aC9kYl9oZWFsdGhfcHJvdmlkZXIucHk=) | `82.75% <ø> (ø)` | | | [pyctuator/impl/spring\_boot\_admin\_registration.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvc3ByaW5nX2Jvb3RfYWRtaW5fcmVnaXN0cmF0aW9uLnB5) | `82.97% <75.00%> (-0.54%)` | :arrow_down: | | [pyctuator/health/health\_provider.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2hlYWx0aC9oZWFsdGhfcHJvdmlkZXIucHk=) | `90.32% <100.00%> (+3.36%)` | :arrow_up: | | [pyctuator/impl/aiohttp\_pyctuator.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvYWlvaHR0cF9weWN0dWF0b3IucHk=) | `97.46% <100.00%> (+0.03%)` | :arrow_up: | | [pyctuator/impl/fastapi\_pyctuator.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvZmFzdGFwaV9weWN0dWF0b3IucHk=) | `99.02% <100.00%> (+0.01%)` | :arrow_up: | | [pyctuator/impl/flask\_pyctuator.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvZmxhc2tfcHljdHVhdG9yLnB5) | `98.97% <100.00%> (+0.01%)` | :arrow_up: | | [pyctuator/impl/pyctuator\_impl.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvcHljdHVhdG9yX2ltcGwucHk=) | `94.89% <100.00%> (+0.27%)` | :arrow_up: | | [pyctuator/impl/tornado\_pyctuator.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2ltcGwvdG9ybmFkb19weWN0dWF0b3IucHk=) | `95.72% <100.00%> (+0.07%)` | :arrow_up: | | [pyctuator/auth.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2F1dGgucHk=) | `100.00% <0.00%> (ø)` | | | [pyctuator/httptrace/\_\_init\_\_.py](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHljdHVhdG9yL2h0dHB0cmFjZS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/SolarEdgeTech/pyctuator/pull/83/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.