search

SolarLiner / bevy-kira-components

Experimental Bevy <-> Kira integration crate
https://solarliner.dev/bevy-kira-components/bevy_kira_components/
MIT License
8 stars 6 forks source link

Remove Cargo.lock #10

Closed GitGhillie closed 2 months ago

GitGhillie commented 2 months ago

It's not necessary for libraries and will make the diffs less noisy

SolarLiner commented 2 months ago

I'll note I fully disagree with this. Build reproducibility is still important for libraries, especially non-stable ones, where a difference in dependency resolution can cause conflicts and introduce bugs. I'm okay with noisy diffs on the lock, and it's fine to just ignore it entirely. I never agreed with Rust guidelines on this for the reason above. It's also a problem for build systems with reproducibility in mind (like NixOS) because they rely on Cargo.lock already being derived as their source of truth when downloading dependencies.

I'll approve because it's the decision that Bevy took, and so it makes sense to do the same. But I'll groan and complain about it a little bit 😆

EDIT: The guidelines have changed Aug. 2023, and lockfiles are not advised to be ignored for libraries anymore.

GitGhillie commented 2 months ago

Well, TIL. I could swear it wasn't too long ago that I did cargo new --lib and it added the lock file to the gitignore, but I guess I'm misremembering. Feel free to close this :)

GitGhillie commented 2 months ago

Oops I closed it, but I think you were leaning in that direction anyways xd

SolarLiner commented 2 months ago

Yeah either case we'll remove it during up streaming probably