search

SolarLiner / bevy-kira-components

Experimental Bevy <-> Kira integration crate
https://solarliner.dev/bevy-kira-components/bevy_kira_components/
MIT License
9 stars 6 forks source link

Recreate audio_control example #9

Closed GitGhillie closed 6 months ago

GitGhillie commented 6 months ago

Description

Recreated the audio_control example from Bevy.

Run with cargo run --example audio_control. I didn't add Windless Slopes.ogg because I wasn't sure if I could just do that, so let me know what the preference is there.

SolarLiner commented 6 months ago

I didn't add Windless Slopes.ogg because I wasn't sure if I could just do that

You bring a good point, and that makes me think that I added the drums asset to the examples without too much care for usage rights -- however since this crate is supposed to be upstreamed, it shouldn't be too much of an issue for Windless Slopes (and in fact all examples should use it instead). I definitely would ping a Bevy maintainer about it though!

SolarLiner commented 6 months ago

It looks like adding bevy as a dev-dependency broke the doc test in src/lib.rs:29, probably because the default features were turned back on. Not sure what's the best way to resolve it.

GitGhillie commented 6 months ago

Hmm pushing commits doesn't seem to trigger a re-run of the CI so it's hard to try out a fix for the test...

I'll ping a maintainer about the Windless Slopes question tomorrow!

SolarLiner commented 6 months ago

re. Windless Slopes, it's from this pack, which has a CC0 1.0 license attached to it, so it's fine to include it here.

SolarLiner commented 6 months ago

pushing commits doesn't seem to trigger a re-run of the CI so it's hard to try out a fix for the test...

Looks like as a "first-time contributor" I'll need to approve all your runs? At least for your next PR it might work better 🙃

GitGhillie commented 6 months ago

Ha interesting, I'll try to reproduce it locally in the meantime

GitGhillie commented 6 months ago

I think I found the solution. By using no_run the doc example will still build but it won't try to run it. Which I think is the intention anyways

GitGhillie commented 6 months ago

Just in case you're waiting for me: I don't have a merge button 😛

SolarLiner commented 6 months ago

Ha, that's another thing I didn't know lol, it'd be nice if you could, I'll look into the settings.

SolarLiner commented 6 months ago

Well, I guess there's no other way than to have me be the one clicking on the button, so be it