search

SolarLune / masterplan

MasterPlan is a project management software / visual idea board software. It attempts to be easy to use, lightweight, and fun.
https://solarlune.itch.io/masterplan
512 stars 46 forks source link

Incorrect colors when creating custom theme #6

Closed bcaccia closed 4 years ago

bcaccia commented 4 years ago

Environment:

Repro:

  1. Duplicate an existing theme in /masterplan/bin/linux_amd64/assets/themes and rename it. I called mine Gruvbox_dark.json
  2. Change the GUI_INSIDE property in the json file to an obvious color such as 204, 36, 29, 1
  3. Save the changes, launch Masterplan, and load your theme.

Expected: The background will be the following color: image

Bug:

The background is black: image

If I change every value in the Gruvbox_dark.json file to that red, the whole UI is completely black. To rule out that just that color was an issue, I tested with several other colors from the Gruvbox palette located here: https://github.com/morhetz/gruvbox

SolarLune commented 4 years ago

The alpha argument in your example is 1, which is basically invisible. The format for each color defined in themes is RGBA. Each value spans from 0 to 255 max.

bcaccia commented 4 years ago

Thanks, total user error. Confirmed this works correctly when the value is set to 255. This can be closed.

SolarLune commented 4 years ago

OK, cool, just wanted to be sure. Thanks!