search

SolarLune / masterplan

MasterPlan is a project management software / visual idea board software. It attempts to be easy to use, lightweight, and fun.
https://solarlune.itch.io/masterplan
509 stars 46 forks source link

Don't allow numbered cards to have negative tasks completed #68

Closed Peter0x44 closed 2 years ago

Peter0x44 commented 2 years ago

Currently, if you press - on a numbered card, you can have a negative number for the amount of completed tasks This is a one-line change, it should be pretty self-explanatory

SolarLune commented 2 years ago

Hello! Thanks for the PR! However, I think NumberSpinner should be able to go negative (I can't think of any circumstances where I would want it to, but there could be such situations in some cases). I believe the correct solution to this is to set the minimum for the Current and Max NumberSpinners in NumberedContents, specifically.

Peter0x44 commented 2 years ago

OK, is it all good now?

set the minimum for the Current and Max NumberSpinners in NumberedContents, specifically

I don't believe this is necessary for the max NumberSpinner, because its value can't go below the current NumberSpinner anyway

SolarLune commented 2 years ago

Excellent - thank you very much for the PR!