Eldritch smite pops up only when a critical hit

[HIEROT]

It should behave like a paladin's smite, and possibly it will be very nice if a button to on/off critical smite is provided just like a paladin AutoSave_2.sav.zip Thank you in advance!

[HIEROT]

And I remember in the last few versions of mod, it behaves as it should be. Maybe something was modified unexpectedly

[ThyWoof]

In fact there is an option for that. Are you sure you don't have Enable Paladin Smite Toggle enabled and forgot to enable the toggle?

this is the logic there.

                        // This is used to only offer smites on critical hits
                        if (!criticalHit &&
                            Main.Settings.AddPaladinSmiteToggle &&
                            !hero.IsToggleEnabled((ActionDefinitions.Id)ExtraActionId.PaladinSmiteToggle))
                        {
                            break;
                        }

here without setting enabled on Mod UI.

toggle disabled. no smites offered.

not a bug.

[HIEROT]

I mean the toggle of invocation eldritch smite of a warlock. I was sure that the toggle for a paladin is there but not for a warlock.

[ThyWoof]

Oh I see. Will check

[ThyWoof]

fixed in dev.

added an additional check to let this smite type go without the toggle. For now won't add any toggle.

                        // This is used to only offer smites on critical hits
                        if (!criticalHit &&
                            // allows EldritchSmite to pass through
                            featureDefinition is not FeatureDefinitionAdditionalDamage &&
                            // allows PaladinSmite to pass through
                            Main.Settings.AddPaladinSmiteToggle &&
                            !hero.IsToggleEnabled((ActionDefinitions.Id)ExtraActionId.PaladinSmiteToggle))
                        {
                            break;
                        }

[HIEROT]

@ThyWoof In the newest version after POI is released, the problem seems to happen again.

[HIEROT]

if (!criticalHit && Main.Settings.AddPaladinSmiteToggle && featureDefinition is not FeatureDefinitionAdditionalDamage && !hero.IsToggleEnabled((ActionDefinitions.Id)ExtraActionId.PaladinSmiteToggle)) { break; } I noticed that the not is missing in the newest dev. Adding it fixs the issue.