Display section not updating after adding anything

SolderedElectronics / Inkplate-GUI-Designer

Web app to easily design user interface for Inkplate boards.

20 stars 8 forks source link

Display section not updating after adding anything #4

Closed gelse closed 2 years ago

gelse commented 3 years ago

Browsers: both Firefox and Chromium

Reproduction:

Open the visual editor
add any widget from this point on the canvas section does not update any more.

Found exceptions:

on loading the page, there is a nullref exception in document.getElementById("imageFile").onchange = ...
when adding any other item but the first, there is a ReferenceError: color is not defined

K-Francis-H commented 2 years ago

Yeah I had the same issue. It looks like the variable color isn't defined in any of the drawing functions for Inkplate.js but a function parameter c is. So I added this line to the top of each drawing function in Inkplate.js: let color = c ?? this.color; . That will correctly use the function param or fallback to the color value defined in the class if c is not defined. I'll try and make a pull request as well

nitko12 commented 2 years ago

Thanks for letting us know, I think I've fixed this now, if it persists please reopen the issue.