Using annotations instead of Facets

SoliDry / api-generator

PHP-code generator for Laravel framework, with complete support of JSON-API data format

MIT License

327 stars 60 forks source link

Using annotations instead of Facets #108

Closed imissyouso closed 6 years ago

imissyouso commented 6 years ago

Hi. Thank you for you job! Nice implementation. I think types annotation is more suitable for adding meta information into RAML definition. What do you think?

arthurkushman commented 6 years ago

Hi, it is definitely pertinent remark, I've also thought about this implementation, but didn't find good implementation and/or stumbled with other inconveniences with parsing comments. As I recollect alecsammon/php-raml-parser lib doesn't support proper parsing of comments in yaml types.