search

SoliDry / api-generator

PHP-code generator for Laravel framework, with complete support of JSON-API data format
MIT License
327 stars 60 forks source link

request : raml validator #118

Closed Tazoeur closed 5 years ago

Tazoeur commented 5 years ago

Hi,

I just found your dev and it looks awesome. I had some troubles to achieve an import on a quite simple API designed with https://studio.restlet.com/

Maybe adding a raml validator as a command or at least a dry-run option would be interesting.

What do you think ? Regards, Guillaume

arthurkushman commented 5 years ago

Hi, it is great idea, that is why open-source is a good place for such projects. Do u mean raml validation based on custom types for raml-json-api or more formal for raml?

Tazoeur commented 5 years ago

I took some time to realize that the validation of a raml file was unsuitable for the raml-json-api. And it was a patience challenge to be able to generate the code with a raml file.

At first, the validator should be used to point out where the raml-json-api went into trouble while parsing the file.

I understand that you had to use some tricks to be able to give the raml file more meaning to implement a decent object code generation, but don't you think that it will be beneficial that, at the end, your package just sticks with the raml specification ?

arthurkushman commented 5 years ago

I suppose U would recommend an OAS/swagger? many people told me that =) I think it would be perspective to implement this type of input data format. Or by beneficial u mean - more abstract version to everything? Is it possible?

arthurkushman commented 5 years ago

Now this repo is Open API Specification based code generator, in other words OAS = Swagger + RAML, which is best for future dev. Thanks for reminding me about this perspective.

arthurkushman commented 5 years ago

Now there are validation rules for required and custom types.