SolidBench / SolidBench.js

A benchmark for Solid to simulate vaults with social network data.
MIT License
10 stars 11 forks source link

fix: Missing tagclass objects #10

Closed jitsedesmet closed 10 months ago

jitsedesmet commented 10 months ago

This PR aims to close #9 and depends on https://github.com/SolidBench/rdf-dataset-fragmenter.js/pull/17 . Notice: normal blank nodes get inserted into the same file. This is not possible for the tagclass-typed objects because the objects get referenced from multiple files. To get the same semantics as with the SNB ttl file, I suggest to translate the blank node to a named one.

jitsedesmet commented 10 months ago

To finish this PR I should also change the graph in the readme. @rubensworks could you provide me with the source code of that graph?

jitsedesmet commented 10 months ago

I just realized it is part of another repository, and I don't know if I am confident enough to change it there. I can open this PR however :D

rubensworks commented 10 months ago

Could you also bump rdf-dataset-fragmenter here? CI will fail without it.

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 6610416552


Totals Coverage Status
Change from base Build 6083459568: 0.0%
Covered Lines: 116
Relevant Lines: 116

💛 - Coveralls