Update dependencies and separate configs to their own files

SolidBench / SolidBench.js

A benchmark for Solid to simulate vaults with social network data.

MIT License

10 stars 11 forks source link

Update dependencies and separate configs to their own files #13

Closed surilindur closed 4 months ago

surilindur commented 4 months ago

Here is a set of changes to:

Move the Jest configs to their own file
Update to Husky version 9, and updating the hook configurations and gitignore
Removing coveralls as unnecessary, because coverage is collected by Jest and the reporting is done through the GitHub Actions version of coveralls
Bumping @rubensworks/eslint-config to version 3 and fixing the linter errors that popped up
Simplifications to tsconfig.json includes and excludes
Relocating index.ts to lib/
Updating the Actions workflow versions to latest ones to get rid of the deprecation warnings

Any feedback would be welcome! I will make a separate PR to use the new fragmenter version when it gets released.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8938694463

Details

21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8927384227:	0.0%
Covered Lines:	115
Relevant Lines:	115

💛 - Coveralls

rubensworks commented 4 months ago

Just had a look, and everything looks good. Since the fragmenter has been released as well, feel free to make the new PR :-)

surilindur commented 4 months ago

This is now finally ready for review! :snail:

rubensworks commented 4 months ago

Thanks!

Is a release for this needed already? (I guess major) Or are more changes planned?

surilindur commented 4 months ago

Besides the work on multiple interfaces, I do not have any plans at the moment.

Looking at the commit history, I think the only breaking changes are around the (default) CSS version used for serving the content. Is it something that would require a major version bump? The other changes seem to be just a bugfix from Jitse, the various dependency updates and clean-up, but there are no changes to the SolidBench things themselves. Relocating index.ts to lib/ should not break anything, since the package.json path for it was also updated, and I doubt anyone directly imports it by path (I hope).